diff --git a/include/key_parser.h b/include/key_parser.h index dcf99f4384d9d6ee04ab9ac3ba7064072fad73c9..a4cedaa09ffd28e35b2a7bc4f98b4f765b760a49 100644 --- a/include/key_parser.h +++ b/include/key_parser.h @@ -28,8 +28,10 @@ public: private: typedef bool (*parse_key_founction)(const std::string &folderName, std::vector &keyparams); - static bool ParseMatch(const std::vector &keys, std::vector &keyparams, const std::vector &founctions); - static bool ParseMatchBySeq(const std::vector &keys, std::vector &keyparams, const std::vector &founctions); + static bool ParseMatch(const std::vector &keys, + std::vector &keyparams, const std::vector &founctions); + static bool ParseMatchBySeq(const std::vector &keys, + std::vector &keyparams, const std::vector &founctions); static bool ParseMccMnc(const std::string &folderName, std::vector &keyparams); static bool ParseMcc(const std::string &folderName, std::vector &keyparams); diff --git a/include/resource_util.h b/include/resource_util.h index b5698f60008cbe54d40a8497f60b4d9d3dc6a5b2..73e775cfca7b18fabf975a0f8502b7fe3df41ca8 100644 --- a/include/resource_util.h +++ b/include/resource_util.h @@ -24,7 +24,6 @@ namespace OHOS { namespace Global { namespace Restool { - class ResourceUtil { public: /** diff --git a/include/task_handle.h b/include/task_handle.h index 8100e9606971a29f37e90de6f59dc8710257076f..72daadfa0d94686fd63aab949259ff3fde898e9c 100644 --- a/include/task_handle.h +++ b/include/task_handle.h @@ -21,7 +21,6 @@ namespace OHOS { namespace Global { namespace Restool { - class TaskHandle { public: TaskHandle() {}; diff --git a/src/cmd_parser.cpp b/src/cmd_parser.cpp index 3cfc29bd74ba2c0b5123cc3ce5a088a731fad975..9cc94d490922c9356bebfaa4c5659e27fc593f31 100644 --- a/src/cmd_parser.cpp +++ b/src/cmd_parser.cpp @@ -302,7 +302,7 @@ uint32_t PackageParser::ParseCommand(int argc, char *argv[]) restoolPath_ = string(argv[0]); while (true) { int optIndex = 0; - int c = getopt_long(argc, argv, CMD_PARAMS.c_str(), CMD_OPTS,&optIndex); + int c = getopt_long(argc, argv, CMD_PARAMS.c_str(), CMD_OPTS, &optIndex); if (c == -1) { break; } diff --git a/src/config_parser.cpp b/src/config_parser.cpp index 15e5f006406b44baffb03a20eb13d7e7d665c637..da29d9bbf6017d59e3969aced3f16b3e8ce1feeb 100644 --- a/src/config_parser.cpp +++ b/src/config_parser.cpp @@ -45,12 +45,12 @@ const map ConfigParser::JSON_ARRAY_IDS = { bool ConfigParser::useModule_ = false; ConfigParser::ConfigParser() - : filePath_("") ,packageName_("") ,moduleName_(""), moduleType_(ModuleType::NONE) + : filePath_(""), packageName_(""), moduleName_(""), moduleType_(ModuleType::NONE) { } ConfigParser::ConfigParser(const string &filePath) - : filePath_(filePath) ,packageName_("") ,moduleName_(""), moduleType_(ModuleType::NONE) + : filePath_(filePath), packageName_(""), moduleName_(""), moduleType_(ModuleType::NONE) { } diff --git a/src/file_manager.cpp b/src/file_manager.cpp index 0d02214cfe59a67dafddfebdba9d9c1057a0f8b2..c8f0fbf454a2790a048bdcf9c0efadd614b04693 100644 --- a/src/file_manager.cpp +++ b/src/file_manager.cpp @@ -52,7 +52,7 @@ uint32_t FileManager::ScanIncrement(const string &output) return ParseReference(output, sxmlFolders); } -//below private founction +// below private founction uint32_t FileManager::ScanModule(const string &input, const string &output, map> &resTypeOfDirs) { diff --git a/src/generic_compiler.cpp b/src/generic_compiler.cpp index 727c72d3995fdea7816c7eac3b0b410d7e7a5411..96f1646dc3b4732e720b9924e6d912eb710eef76 100644 --- a/src/generic_compiler.cpp +++ b/src/generic_compiler.cpp @@ -16,8 +16,8 @@ #include "generic_compiler.h" #include #include -#include "restool_errors.h" #include "resource_util.h" +#include "restool_errors.h" namespace OHOS { namespace Global { diff --git a/src/header.cpp b/src/header.cpp index d86de9c04a3b8cf2e88259d7f868c79076455866..5a99bb57fd4465f2bbe8e4fad203c680543d0061 100644 --- a/src/header.cpp +++ b/src/header.cpp @@ -16,8 +16,8 @@ #include "header.h" #include #include -#include #include +#include namespace OHOS { namespace Global { diff --git a/src/id_worker.cpp b/src/id_worker.cpp index 4bc0827022e3ec00f0f26f7b5715018093c00fde..45c4d46acb779c16e0b32a46eef8e90a8922026e 100644 --- a/src/id_worker.cpp +++ b/src/id_worker.cpp @@ -173,11 +173,11 @@ uint32_t IdWorker::InitIdDefined() string idDefinedPath; if (type_ == ResourceIdCluster::RES_ID_SYS) { for (const auto &inputPath : packageParser.GetInputs()) { - idDefinedPath = filesystem::path(inputPath).append(RESOURCES_DIR) - .append("base").append("element").append(ID_DEFINED_FILE).string(); - if (InitIdDefined(idDefinedPath) != RESTOOL_SUCCESS) { - return RESTOOL_ERROR; - } + idDefinedPath = filesystem::path(inputPath).append(RESOURCES_DIR) + .append("base").append("element").append(ID_DEFINED_FILE).string(); + if (InitIdDefined(idDefinedPath) != RESTOOL_SUCCESS) { + return RESTOOL_ERROR; + } } return RESTOOL_SUCCESS; } diff --git a/src/json_compiler.cpp b/src/json_compiler.cpp index 0b69b9a79bfc2a89459e1dfc58a6743c47d60067..2b40172a92510bae458002bfbb6fbd9df7b1060b 100644 --- a/src/json_compiler.cpp +++ b/src/json_compiler.cpp @@ -76,7 +76,7 @@ uint32_t JsonCompiler::CompileSingleFile(const FileInfo &fileInfo) return RESTOOL_SUCCESS; } -//below private +// below private void JsonCompiler::InitParser() { using namespace placeholders; @@ -169,12 +169,12 @@ bool JsonCompiler::HandleBoolean(const Json::Value &objectNode, ResourceItem &re { Json::Value valueNode = objectNode[TAG_VALUE]; if (valueNode.isString()) { - regex ref("^\\$boolean:.*"); - if (!regex_match(valueNode.asString(), ref)) { - cerr << "Error: '" << valueNode.asString() << "' only refer '$boolean:xxx',"; - cerr << resourceItem.GetFilePath() << endl; - return false; - } + regex ref("^\\$boolean:.*"); + if (!regex_match(valueNode.asString(), ref)) { + cerr << "Error: '" << valueNode.asString() << "' only refer '$boolean:xxx',"; + cerr << resourceItem.GetFilePath() << endl; + return false; + } } else if (!valueNode.isBool()) { cerr << "Error: '" << resourceItem.GetName() << "' value not boolean," << resourceItem.GetFilePath() << endl; return false; diff --git a/src/key_parser.cpp b/src/key_parser.cpp index 3368d738c90ba6b01dcae4d14be43ef16011a349..cb0411309ed3264634051eba7f36cd4f871c11b0 100644 --- a/src/key_parser.cpp +++ b/src/key_parser.cpp @@ -51,7 +51,8 @@ bool KeyParser::Parse(const string &folderName, vector &keyparams) return true; } -bool KeyParser::ParseMatch(const vector &keys, vector &keyparams, const vector &founctions) +bool KeyParser::ParseMatch(const vector &keys, + vector &keyparams, const vector &founctions) { size_t next = 0; for (const auto &key : keys) { @@ -71,7 +72,8 @@ bool KeyParser::ParseMatch(const vector &keys, vector &keypara return true; } -bool KeyParser::ParseMatchBySeq(const vector &keys, vector &keyparams, const vector &founctions) +bool KeyParser::ParseMatchBySeq(const vector &keys, + vector &keyparams, const vector &founctions) { for (size_t i = 0; i < keys.size(); i++) { if (!founctions[i](keys[i], keyparams)) { diff --git a/src/reference_parser.cpp b/src/reference_parser.cpp index 530c9444aa7817a381a9fe5fedf8b1edc5dadd35..3c005328a82d3320f8c7ad05c51470f0db5bc7ad 100644 --- a/src/reference_parser.cpp +++ b/src/reference_parser.cpp @@ -24,35 +24,35 @@ namespace Global { namespace Restool { using namespace std; const map ReferenceParser::ID_REFS = { - { "^\\$id:", ResType::ID }, - { "^\\$boolean:", ResType::BOOLEAN }, - { "^\\$color:", ResType::COLOR }, - { "^\\$float:", ResType::FLOAT }, - { "^\\$media:", ResType::MEDIA }, - { "^\\$profile:", ResType::PROF }, - { "^\\$integer:", ResType::INTEGER }, - { "^\\$string:", ResType::STRING }, - { "^\\$layout:", ResType::LAYOUT }, - { "^\\$pattern:", ResType::PATTERN }, - { "^\\$plural:", ResType::PLURAL }, - { "^\\$graphic:", ResType::GRAPHIC }, - { "^\\$theme:", ResType::THEME } + { "^\\$id:", ResType::ID }, + { "^\\$boolean:", ResType::BOOLEAN }, + { "^\\$color:", ResType::COLOR }, + { "^\\$float:", ResType::FLOAT }, + { "^\\$media:", ResType::MEDIA }, + { "^\\$profile:", ResType::PROF }, + { "^\\$integer:", ResType::INTEGER }, + { "^\\$string:", ResType::STRING }, + { "^\\$layout:", ResType::LAYOUT }, + { "^\\$pattern:", ResType::PATTERN }, + { "^\\$plural:", ResType::PLURAL }, + { "^\\$graphic:", ResType::GRAPHIC }, + { "^\\$theme:", ResType::THEME } }; const map ReferenceParser::ID_OHOS_REFS = { - { "^\\$ohos:id:", ResType::ID }, - { "^\\$ohos:boolean:", ResType::BOOLEAN }, - { "^\\$ohos:color:", ResType::COLOR }, - { "^\\$ohos:float:", ResType::FLOAT }, - { "^\\$ohos:media:", ResType::MEDIA }, - { "^\\$ohos:profile:", ResType::PROF }, - { "^\\$ohos:integer:", ResType::INTEGER }, - { "^\\$ohos:string:", ResType::STRING }, - { "^\\$ohos:layout:", ResType::LAYOUT }, - { "^\\$ohos:pattern:", ResType::PATTERN }, - { "^\\$ohos:plural:", ResType::PLURAL }, - { "^\\$ohos:graphic:", ResType::GRAPHIC }, - { "^\\$ohos:theme:", ResType::THEME } + { "^\\$ohos:id:", ResType::ID }, + { "^\\$ohos:boolean:", ResType::BOOLEAN }, + { "^\\$ohos:color:", ResType::COLOR }, + { "^\\$ohos:float:", ResType::FLOAT }, + { "^\\$ohos:media:", ResType::MEDIA }, + { "^\\$ohos:profile:", ResType::PROF }, + { "^\\$ohos:integer:", ResType::INTEGER }, + { "^\\$ohos:string:", ResType::STRING }, + { "^\\$ohos:layout:", ResType::LAYOUT }, + { "^\\$ohos:pattern:", ResType::PATTERN }, + { "^\\$ohos:plural:", ResType::PLURAL }, + { "^\\$ohos:graphic:", ResType::GRAPHIC }, + { "^\\$ohos:theme:", ResType::THEME } }; ReferenceParser::ReferenceParser() : idWorker_(IdWorker::GetInstance()) @@ -75,7 +75,7 @@ uint32_t ReferenceParser::ParseRefInSolidXml(const vector &solidXmlFolde XmlKeyNode xmlKeyNode; if (!xmlKeyNode.LoadFromFile(filePath, [this](auto &key) -> bool { return ParseRefString(key); - })) { + })) { return RESTOOL_ERROR; } @@ -103,10 +103,10 @@ uint32_t ReferenceParser::ParseRefInElement(map> & uint32_t ReferenceParser::ParseRefInString(string &value, bool &update) const { - if (ParseRefString(value, update)) { - return RESTOOL_SUCCESS; - } - return RESTOOL_ERROR; + if (ParseRefString(value, update)) { + return RESTOOL_SUCCESS; + } + return RESTOOL_ERROR; } uint32_t ReferenceParser::ParseRefInProfile(const string &output) const @@ -156,7 +156,7 @@ bool ReferenceParser::ParseRefResourceItem(ResourceItem &resourceItem) const string data; bool update = false; if (IsStringOfResourceItem(resType)) { - data= string(reinterpret_cast(resourceItem.GetData()), resourceItem.GetDataLength()); + data = string(reinterpret_cast(resourceItem.GetData()), resourceItem.GetDataLength()); if (!ParseRefString(data, update)) { cerr << "Error: in " << resourceItem.GetFilePath() << endl; return false; diff --git a/src/resource_item.cpp b/src/resource_item.cpp index d11b6d03da0d07c91190404123d647a5e74600a4..c84a5f9890cb12f3317c1e62a849fd1ef665ead5 100644 --- a/src/resource_item.cpp +++ b/src/resource_item.cpp @@ -31,7 +31,7 @@ ResourceItem::ResourceItem(const ResourceItem &other) } ResourceItem::ResourceItem(const string &name, const vector &keyparams, ResType type) - :data_(nullptr), dataLen_(0), name_(name),keyparams_(keyparams), type_(type) + : data_(nullptr), dataLen_(0), name_(name), keyparams_(keyparams), type_(type) { } @@ -118,7 +118,7 @@ ResourceItem &ResourceItem::operator=(const ResourceItem &other) return *this; } -//below private founction +// below private founction void ResourceItem::ReleaseData() { if (data_ != nullptr) { diff --git a/src/resource_pack.cpp b/src/resource_pack.cpp index 94792d0fb53c36f157efbf44bff60684c48e18e0..eeb22e72658c8048742b6ff3e792ec2088d84039 100644 --- a/src/resource_pack.cpp +++ b/src/resource_pack.cpp @@ -71,7 +71,7 @@ uint32_t ResourcePack::Package() return RESTOOL_SUCCESS; } -//below private founction +// below private founction uint32_t ResourcePack::Init() { InitHeaderCreater(); @@ -185,7 +185,7 @@ uint32_t ResourcePack::InitConfigJson() { string config = packageParser_.GetConfig(); if (config.empty()) { - if( packageParser_.GetInputs().size() > 1) { + if (packageParser_.GetInputs().size() > 1) { cerr << "Error: more input path, -j config.json empty" << endl; return RESTOOL_ERROR; } @@ -234,8 +234,7 @@ uint32_t ResourcePack::GenerateCplusHeader(const string &headerPath) const buffer << "#define RESOURCE_TABLE_H\n\n"; buffer << "#include\n\n"; buffer << "namespace OHOS {\n"; - }, - [](stringstream &buffer, const IdWorker::ResourceId& resourceId) { + }, [](stringstream &buffer, const IdWorker::ResourceId& resourceId) { string name = resourceId.type + "_" + resourceId.name; transform(name.begin(), name.end(), name.begin(), ::toupper); buffer << "const int32_t " << name << " = "; @@ -254,8 +253,7 @@ uint32_t ResourcePack::GenerateJsHeader(const std::string &headerPath) const uint32_t result = JsHeader.Create([](stringstream &buffer) { buffer << Header::LICENSE_HEADER << "\n"; buffer << "export default {\n"; - }, - [&itemType](stringstream &buffer, const IdWorker::ResourceId& resourceId) { + }, [&itemType](stringstream &buffer, const IdWorker::ResourceId& resourceId) { if (itemType != resourceId.type) { if (!itemType.empty()) { buffer << "\n" << " " << "},\n"; diff --git a/src/resource_table.cpp b/src/resource_table.cpp index abfa1b774120a175a6bd4f9fe08297914305d578..caa9c7f845b9558cc7818854d77603cd896e07b5 100644 --- a/src/resource_table.cpp +++ b/src/resource_table.cpp @@ -15,9 +15,9 @@ #include "resource_table.h" #include -#include "securec.h" #include "cmd_parser.h" #include "file_manager.h" +#include "securec.h" #include "resource_util.h" namespace OHOS { diff --git a/src/resource_util.cpp b/src/resource_util.cpp index 530fabe01237134f2a30641c0c388203d3d0ebb0..81f3cb40c1390a70324bb825117c65caeb79ad06 100644 --- a/src/resource_util.cpp +++ b/src/resource_util.cpp @@ -34,7 +34,7 @@ const map ResourceUtil::IGNORE_FILE_REGEX = { { "desktop\\.ini", IgnoreType::IGNORE_ALL }, { "picasa\\.ini", IgnoreType::IGNORE_ALL }, { "\\..+", IgnoreType::IGNORE_ALL }, - { "_.+",IgnoreType::IGNORE_DIR }, + { "_.+", IgnoreType::IGNORE_DIR }, { "cvs", IgnoreType::IGNORE_ALL }, { "thumbs\\.db", IgnoreType::IGNORE_ALL }, { ".+~", IgnoreType::IGNORE_ALL } @@ -88,7 +88,7 @@ bool ResourceUtil::OpenJsonFile(const string &path, Json::Value &root) readBuilder["collectComments"] = false; readBuilder["failIfExtra"] = true; JSONCPP_STRING errs; - if(!parseFromStream(readBuilder, ifs, &root, &errs)) { + if (!parseFromStream(readBuilder, ifs, &root, &errs)) { cerr << "Error: parseFromStream '" << path; cerr << "\n" << errs << endl; ifs.close(); @@ -144,7 +144,7 @@ string ResourceUtil::ResTypeToString(ResType type) string ResourceUtil::GetIdName(const string &name, ResType type) { if (type != ResType::MEDIA && type != ResType::LAYOUT && type != ResType::PROF && - type != ResType::ANIMATION && type != ResType::GRAPHIC ) { + type != ResType::ANIMATION && type != ResType::GRAPHIC) { return name; } diff --git a/src/restool.cpp b/src/restool.cpp index 979e2888d7d85576df4dc49275a717083ab2c568..3da2fca9841a893e7aff76b966a43aee807d8315 100644 --- a/src/restool.cpp +++ b/src/restool.cpp @@ -19,7 +19,8 @@ using namespace std; using namespace OHOS::Global::Restool; -uint32_t ProccssHap(PackageParser &packageParser) { +uint32_t ProccssHap(PackageParser &packageParser) +{ TaskHandle taskHandle; return taskHandle.HandlePackage(packageParser); } diff --git a/src/solid_xml_compiler.cpp b/src/solid_xml_compiler.cpp index 8efbbde76aa90af8072d853a64673920bcb55b96..fd2c2d8462b3523b35e0a9f57ff22e582240f2ec 100644 --- a/src/solid_xml_compiler.cpp +++ b/src/solid_xml_compiler.cpp @@ -17,8 +17,8 @@ #include #include #include -#include "restool_errors.h" #include "resource_util.h" +#include "restool_errors.h" namespace OHOS { namespace Global { diff --git a/src/xml/solid_xml.cpp b/src/xml/solid_xml.cpp index 26cfe5c1f314fabd91b5ea72237311e25ba07900..50645b093df33ae266536ee7535c740d16b6975d 100644 --- a/src/xml/solid_xml.cpp +++ b/src/xml/solid_xml.cpp @@ -78,7 +78,7 @@ bool SolidXml::FlushNodeKeys(const string &filePath, map &node) { if (nodePtr->type == XML_COMMENT_NODE) { @@ -119,7 +119,7 @@ void SolidXml::CompileAttr(const xmlAttrPtr attrPtr, shared_ptr &node) return; } - xmlChar * xmlValue = xmlNodeListGetString(attrPtr->doc, attrPtr->children, 1); + xmlChar *xmlValue = xmlNodeListGetString(attrPtr->doc, attrPtr->children, 1); string value(reinterpret_cast(xmlValue)); PretreatmentAttr(value); xmlFree(xmlValue); diff --git a/src/xml/xml_key_node.cpp b/src/xml/xml_key_node.cpp index f77638a1d81bbff0c128c73f2b44ee60f7d046c4..3b59a5fe41b8e4dc011620314e70b85973d272f8 100644 --- a/src/xml/xml_key_node.cpp +++ b/src/xml/xml_key_node.cpp @@ -56,7 +56,7 @@ bool XmlKeyNode::SaveToFile(const string &filePath) const } vector> sets(keyMap_.begin(), keyMap_.end()); - sort(sets.begin(), sets.end(),[](const auto &a, const auto &b) { + sort(sets.begin(), sets.end(), [](const auto &a, const auto &b) { return a.second < b.second; });