[wip]多级缓存torchrec_embcache python部分 · Pull Request !1069 · Ascend/RecSDK - Gitee

Open Source > AI/ML > Artificial Intelligence &&

Closed

xiangpx-work:develop_dev_cache Ascend:develop

create on 2025-08-09 15:35

Type	Assign personnel	Status
Reviewer	yuncliu chenhangcal 何霖 Taoqiuyu steepcurve zxorange321 SimmerChan longfeifei zhangyuanchuan Atlas_hrp super_liming yangzhen_BIG xiangpx-work 曾伟 wuhongfa lmm221 wuyangjian 吃青椒的喵酱 rome_zhouyang 徐岩 xiangjie yangzhen JiangLi 马千里 sihaixianyu 186******13 penghuiyang 李大雄 liangrenhao yxy1684 xiajunhua 梅三友郭望 tanfeng FangXiongQi zhoucy zhangjinyuan Can	Completed (0/0 )
Tester	SimmerChan	Completed (0/0 )

The Pull Request cannot be automatically merged.

resolve conflicts with WebIDE

Expand Collapse

Reviewer

Reviewer

No Setting

Tester

No Setting

Priority

Label

ci-pipeline-failed

ascend-cla/yes

SC-FAIL

stat/needs-squash

Link Issue

卫语句优化，无需else

增加环境变量资料需同步修改。

numpy属于第三方库

环境变量EMBCACHE_SIZE_ON_DEVICE_MEM是否补充资料说明。

获取local_shard_size的这段逻辑重复，考虑提取公共函数。此外，整个torchrec的重复代码都很多，后续有重构计划吗？

【建议】embedding和embeddingbag中都有这块代码，可以抽取下方法。![输入图片说明](https://foruda.gitee.com/images/1754969668490907522/8d74f5a9_13196642.png "屏幕截图")

【一般】这里timestamp使用约束是长度需要和values长度相同，timestamp非空时增加校验长度和values是否相等。![输入图片说明](https://foruda.gitee.com/images/1754970152615830674/8b05a139_13196642.png "屏幕截图")

【建议】对外接口建议添加到init.py中![输入图片说明](https://foruda.gitee.com/images/1754970306918845009/cfee3f9a_13196642.png "屏幕截图")

【建议】无用代码删除![输入图片说明](https://foruda.gitee.com/images/1754970473821118071/9b281f9f_13196642.png "屏幕截图")

【建议】初始化class的时候已经设置了device, 此处无需“:{rank}”![输入图片说明](https://foruda.gitee.com/images/1754970651805477560/3b8cb9f5_13196642.png "屏幕截图")

卫语句优化

卫语句优化

导包顺序：系统库、第三方、本地库

Successfully merged pull requests will close issues

Milestone

Participators （10）

C++

1

https://gitee.com/ascend/RecSDK.git

[email protected]:ascend/RecSDK.git

ascend

RecSDK

RecSDK